-
-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Remove officially unmaintained project #557
Conversation
Reviewer's Guide by SourceryThis pull request removes a community package from the documentation that is no longer officially supported. The package in question is 'strawberry-django-jwt', which is a JWT implementation with Strawberry and Django. The removal aims to prevent confusion and keep the documentation clean and up to date. File-Level Changes
Tips
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @Eraldo - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟡 Documentation: 1 issue found
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.
@@ -4,7 +4,6 @@ Those are some community maintained projects worth mentioning: | |||
|
|||
| Project | Description | | |||
| :----------------------------------------------------------------------------------------------: | :-------------------------------------------------------------------------------------------------------------------------: | | |||
| [:material-github: strawberry-django-jwt](https://github.com/KundaPanda/strawberry-django-jwt) | :material-information: JWT implementation with Strawberry and Django. | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
question (documentation): Clarify the reason for removing the strawberry-django-jwt project.
Could you please provide the reason for removing the strawberry-django-jwt
project from the documentation? If it was intentional, consider adding a note explaining the reason for future reference.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ty! :)
Description
Removing a community package that is officially not supported anymore and itself refers to the another mentioned (and listed in the docs) package that includes JWT token management.
My personal suggestion would be to remove the stale package to prevent confusing and keep things clean and up to date.
Types of Changes
Summary by Sourcery
This pull request updates the community projects documentation by removing the reference to the unmaintained 'strawberry-django-jwt' project to prevent confusion and keep the documentation up to date.